Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add python 3.12 to CI #184

Merged
merged 10 commits into from
May 3, 2024
Merged

add python 3.12 to CI #184

merged 10 commits into from
May 3, 2024

Conversation

FabianHofmann
Copy link
Collaborator

@FabianHofmann FabianHofmann commented Oct 27, 2023

closes #265

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 84.11%. Comparing base (1e1a123) to head (4972924).

Files Patch % Lines
linopy/solvers.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
- Coverage   88.87%   84.11%   -4.76%     
==========================================
  Files          15       15              
  Lines        3666     3671       +5     
  Branches      860      862       +2     
==========================================
- Hits         3258     3088     -170     
- Misses        283      464     +181     
+ Partials      125      119       -6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maurerle
Copy link
Contributor

maurerle commented Apr 24, 2024

Just to mention that the latest commit messages states to "disable cplex for python < 3.12" while it actually does the opposite (disable it for python >= 3.12). So you might want to --amend that and force push the commit message @FabianHofmann :)

@FabianHofmann FabianHofmann enabled auto-merge May 3, 2024 12:49
@FabianHofmann FabianHofmann merged commit f182b7f into master May 3, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPS IO changes with highspy >= 1.7
3 participants